Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit resource management iterator return #4387

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Explicit resource management iterator return #4387

merged 3 commits into from
Feb 12, 2025

Conversation

debadree25
Copy link

Hello!

This pr splits out tests for whether (Async)Iterator Symbol.dispose calls the return method or not from #3866

Thank you!

@debadree25 debadree25 requested a review from a team as a code owner January 31, 2025 07:35
ptomato
ptomato approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptomato ptomato merged commit ae0656d into tc39:main Feb 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debadree25 @ptomato @rbuckton